Skip to content

CanopyGenerator.cpp:1188 plant_count is not updated #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heesup wants to merge 1 commit into from
Closed

CanopyGenerator.cpp:1188 plant_count is not updated #46

heesup wants to merge 1 commit into from

Conversation

@heesup
Copy link
Contributor

@heesup heesup commented Nov 15, 2024

Changed from

    int2 new_plant_count = XMLloadint2(canopy_node, "plant_count");
    if (new_plant_count.x != nullvalue_i && new_plant_count.y != nullvalue_i) {
        plant_count = plant_count;
    }

to

    int2 new_plant_count = XMLloadint2(canopy_node, "plant_count");
    if (new_plant_count.x != nullvalue_i && new_plant_count.y != nullvalue_i) {
        plant_count = new_plant_count;
    }

@heesup
Helios/plugins/canopygenerator/src/CanopyGenerator.cpp:1188:21: warni…
fb90b70 
…ng: assigning field to itself [-Wself-assign-field]
@bnbailey-psl
Copy link
Contributor

bnbailey-psl commented Nov 19, 2024

Fixed in v1.3.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heesup @bnbailey-psl